Certified Platform Developer II Exam - Question 42

Question

trigger AssignOwnerByRegion on Account ( before insert, before update )

{

List accountList = new List();

for( Account anAccount : trigger.new )

{

Region__c theRegion = [

SELECT Id, Name, Region_Manager__c

FROM Region__c -

WHERE Name = :anAccount.Region_Name__c

];

anAccount.OwnerId = theRegion.Region_Manager__c;

accountList.add( anAccount );

}

update accountList;

}

Consider the above trigger intended to assign the Account to the manager of the Account's region.

Which two changes should a developer make in this trigger to adhere to best practices? (Choose two.)

Examice · Accepted Answer

To adhere to best practices, the developer should move the Region__c query to outside the loop to avoid repeated SOQL queries which can lead to performance issues (too many SOQL queries error). Additionally, in 'before' triggers, changes made to the records in trigger.new are automatically saved, so the update DML operation is redundant and should be removed.

sajjankrgupta · Answer

Using a SOQL query inside for loop is bad practice and since it is before insert/update no need to perform DML. 
Ans is B and C.

AB1993 · Answer

B & C is the correct answer

amerbearat · Answer

b and c is the answer as it is a before trigger we don’t need to update the account and soql always outside of the loop

Pratibhadx · Answer

B & C obviously

ram12313 · Answer

B&C is correct if we're only talking about best practices. But we still need to tidy it up a bit like code below. trigger AssignOwnerByRegion on Account ( before insert, before update ) { Set acctRegionNames = new Set(); for( Account acc : Trigger.new){ acctRegionNames.add(acc.Region_Name__c); } Map regionMap = new Map(); for( Region__c reg : [SELECT Name, Region_Manager__c FROM Region__c Name IN :acctRegionNames]){ regionMap.put(reg.Name, reg.Region_Manager__c); } for( Account anAccount : trigger.new ){ if(regionMap.containsKey(anAccount.Name)){ anAccount.OwnerId = regionMap.get(anAccount.Name); } } }

Genki_Sugisaki · Answer

B&C
A is OK if Use a Map to cache the results of the Region__c query by Name

levian · Answer

B and C, for sure

Dean5555 · Answer

B&C it is

sf2022 · Answer

BC are correct answers

amilaveer · Answer

B & C are correc t

MetaLojiqTee · Answer

B) Performing Queries inside a loop is not good practice, C) Changes made to records retrieved from 'Before' trigger context are automatically persisted if the trigger transaction completes successfully

Jeet89123 · Answer

B and C correct as per best parctices

Certified Platform Developer II Exam - Question 42

Discussion